Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751568 Jon Ciesla <limb@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED CC| |limb@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #3 from Jon Ciesla <limb@xxxxxxxxxxxx> 2011-11-23 09:23:21 EST --- Good: - rpmlint checks return: libgxps.x86_64: W: spelling-error Summary(en_US) GObject -> G Object, Object The value of this tag appears to be misspelled. Please double-check. Ignore. libgxps.x86_64: E: incorrect-fsf-address /usr/share/doc/libgxps-0.1.0/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. Fix at your convenience, not a blocker. 3 packages and 0 specfiles checked; 1 errors, 1 warnings. - package meets naming guidelines - package meets packaging guidelines - license ( LGPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file EXTRA STUFF FOR PACKAGES WITH DEVEL ========================== - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Otherwise it's perfect. Given the practice review, I think I'd like to see one more practice review, and if that's good then I'll be willing to sponsor you and approve this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review