Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756321 Tom Hughes <tom@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tom@xxxxxxxxxx --- Comment #2 from Tom Hughes <tom@xxxxxxxxxx> 2011-11-23 06:20:29 EST --- An informal review as I'm not a sponsored packager yet: Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [!]: MUST ldconfig called in %post and %postun if required. /sbin/ldconfig not called in %post [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contains kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. [x]: MUST Development .so files in -devel subpackage, if present. ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is correct (EPEL5 & Fedora < 10) %{_tmppath}/%{name}-%{version}-%{release}-root [!]: MUST Package contains no bundled libraries. Not sure if the headers from the runtime directory are an issue here? [x]: MUST Changelog in prescribed format. [x]: MUST Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).(EPEL6 & Fedora < 13) [?]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package requires other packages for directories it uses. [-]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of %install. (EPEL5) [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [-]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [!]: MUST Package meets the Packaging Guidelines. Should use %doc to install documentation [x]: MUST Package is named according to the Package Naming Guidelines. [?]: MUST Package does not generates any conflict. [!]: MUST Package obeys FHS, except libexecdir and /usr/target. I don't think compiler_test.in belongs in /usr/bin [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [!]: MUST Requires correct, justified where necessary. Require of base package should use %{?_isa} qualification [!]: MUST Rpmlint output is silent. rpmlint csmith-2.1.0-1.x86_64.rpm ================================================================================ csmith.x86_64: E: script-without-shebang /usr/bin/compiler_test.in csmith.x86_64: W: no-manual-page-for-binary csmith csmith.x86_64: W: no-manual-page-for-binary launchn.pl csmith.x86_64: W: no-manual-page-for-binary compiler_test.pl csmith.x86_64: W: no-manual-page-for-binary test_csmith.pl csmith.x86_64: W: no-manual-page-for-binary compiler_test.in 1 packages and 0 specfiles checked; 1 errors, 5 warnings. ================================================================================ rpmlint csmith-devel-2.1.0-1.x86_64.rpm ================================================================================ csmith-devel.x86_64: W: no-documentation csmith-devel.x86_64: E: incorrect-fsf-address /usr/include/csmith-2.1.0/stdint_ia32.h csmith-devel.x86_64: E: incorrect-fsf-address /usr/include/csmith-2.1.0/stdint_avr.h csmith-devel.x86_64: E: incorrect-fsf-address /usr/include/csmith-2.1.0/stdint_msp430.h csmith-devel.x86_64: E: incorrect-fsf-address /usr/include/csmith-2.1.0/custom_limits.h csmith-devel.x86_64: E: incorrect-fsf-address /usr/include/csmith-2.1.0/stdint_ia64.h 1 packages and 0 specfiles checked; 5 errors, 1 warnings. ================================================================================ rpmlint csmith-2.1.0-1.src.rpm ================================================================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ================================================================================ rpmlint csmith-debuginfo-2.1.0-1.x86_64.rpm ================================================================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ================================================================================ [x]: MUST Sources used to build the package matches the upstream source, as provided in the spec URL. /home/thh/756321/csmith-2.1.0.tar.gz : MD5SUM this package : 3170ce73f0347d82c1206cf145cb49c7 MD5SUM upstream package : 3170ce73f0347d82c1206cf145cb49c7 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Scriptlets must be sane, if used. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: SHOULD Package should compile and build into binary rpms on all supported architectures. [!]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Package contains no bundled libraries. Not sure if the headers from the runtime directory are an issue here? [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST Package meets the Packaging Guidelines. Should use %doc to install documentation [!]: MUST Package obeys FHS, except libexecdir and /usr/target. I don't think compiler_test.in belongs in /usr/bin [!]: MUST Requires correct, justified where necessary. Require of base package should use %{?_isa} qualification [!]: MUST Rpmlint output is silent. rpmlint csmith-2.1.0-1.x86_64.rpm ================================================================================ csmith.x86_64: E: script-without-shebang /usr/bin/compiler_test.in csmith.x86_64: W: no-manual-page-for-binary csmith csmith.x86_64: W: no-manual-page-for-binary launchn.pl csmith.x86_64: W: no-manual-page-for-binary compiler_test.pl csmith.x86_64: W: no-manual-page-for-binary test_csmith.pl csmith.x86_64: W: no-manual-page-for-binary compiler_test.in 1 packages and 0 specfiles checked; 1 errors, 5 warnings. ================================================================================ rpmlint csmith-devel-2.1.0-1.x86_64.rpm ================================================================================ csmith-devel.x86_64: W: no-documentation csmith-devel.x86_64: E: incorrect-fsf-address /usr/include/csmith-2.1.0/stdint_ia32.h csmith-devel.x86_64: E: incorrect-fsf-address /usr/include/csmith-2.1.0/stdint_avr.h csmith-devel.x86_64: E: incorrect-fsf-address /usr/include/csmith-2.1.0/stdint_msp430.h csmith-devel.x86_64: E: incorrect-fsf-address /usr/include/csmith-2.1.0/custom_limits.h csmith-devel.x86_64: E: incorrect-fsf-address /usr/include/csmith-2.1.0/stdint_ia64.h 1 packages and 0 specfiles checked; 5 errors, 1 warnings. ================================================================================ rpmlint csmith-2.1.0-1.src.rpm ================================================================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ================================================================================ rpmlint csmith-debuginfo-2.1.0-1.x86_64.rpm ================================================================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ================================================================================ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review