Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755890 --- Comment #7 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-11-22 20:08:31 EST --- (In reply to comment #5) > > I prefer to use /usr/share/icons/... For instance, if you had a 48x48 and > > scalable (svg) icons named gsnap-48x48.png and gsnap.svg respectively you could > > install them to the following locations (in your makefile or spec): > > > > /usr/share/icons/hicolor/48x48/apps/gsnap.png (notice I rename the file without > > the size) > > /usr/share/icons/hicolor/scalable/apps/gsnap.svg > > > > Then grab them both in %files with: > > > > %{_datadir}/icons/hicolor/*/apps/* > > I just included a scalable svg icon for the time being. This is acceptable > correct? I think that meets the technical requirements, but here's where the guidelines get "fuzzy". The Fedora guidelines[1] say we need to meet the freedesktop desktop entry specs[2], which in turn say we should follow the Icon Theme Specification[3] which says we should install a 48x48 icon as a minimum[4]. Yeah, it's convoluted :) I don't think I'd hold up a review for it, but it's not much work to export a 48x48 icon (png) just to be sure :) Although I would be interested in the results across supported desktops (Gnome 2, Gnome Shell, KDE, XFCE, LXDE, etc.) with only the scalable icon. If someone went to the trouble of testing all those configurations then I think a valid argument can be made to install only a scalable icon. Richard [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files [2] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html [3] http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html [4] http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#install_icons -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review