Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=734410 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |steve.traylen@xxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |steve.traylen@xxxxxxx Flag| |fedora-review? --- Comment #5 from Steve Traylen <steve.traylen@xxxxxxx> 2011-11-22 16:30:15 EST --- Laurence, >Is there a way to automatically generate it or do I >have to copy and paste the variables? this will not help in this case but when the Source is a URL with versions in you can at least run. spectool package.spec to give the URL. Yanko, The informal review is a good review as are your following comments. One change, can you preserve the timestamp on the man page, i.e add -p on install -D -m 644 debian/abootimg.1 ${RPM_BUILD_ROOT}/%{_mandir}/man1/abootimg.1 before import. Assuming that's okay with you. APPROVED. Steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review