Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755155 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Parag AN(पराग) <panemade@xxxxxxxxx> 2011-11-22 06:06:01 EST --- Looks good now. I see that I missed to say that versioned dependencies should be avoided. e.g. in this package BuildRequires written as BuildRequires: perl(TAP::Harness::Archive) >= 0.14 BuildRequires: perl(Test::Harness) >= 3.23 BuildRequires: perl(Test::Simple) >= 0.44 which should be written as BuildRequires: perl(TAP::Harness::Archive) BuildRequires: perl(Test::Harness) BuildRequires: perl(Test::Simple) See http://fedoraproject.org/wiki/Packaging:Guidelines#Requires APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review