Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754064 --- Comment #3 from Jan Kaluža <jkaluza@xxxxxxxxxx> 2011-11-22 05:03:58 EST --- Thanks for reviewing, here is updated spec file and new srpm: Spec URL: http://jkaluza.fedorapeople.org/python-mimeparse.spec SRPM URL: http://jkaluza.fedorapeople.org/python-mimeparse-0.1.3-2.fc16.src.rpm I've found out that python-mimeparse doesn't work correctly with python3, so I disabled building it by setting "with_python3 0". I would like to keep the support for python3 builds there (even in disabled form) to not have to write it again once upstream will support python3. > [!] Package meets packaging guidelines. > CFLAGS are set for the python3 build but not for the python2* build. > Maybe it is not needed at all, but I am not sure about it. It's not needed at all, because there's no compilation, but I would like to keep it there just to be sure in the future. I've added it to python2 build too. > I would prefer summary like: "Python module for parsing mime-type names" or > similar. Added. > [!] BuildRequires are correct. > I cannot find the python-setuptools-devel in rawhide. > Is the python-setuptools really needed? It seems to build OK without it. Hm, I'm not sure why I added it there. Probably copied from another spec file. I removed those requires. > [NO] Spec file has consistant macro usage. > Please use %{optflags} instead of $RPM_OPT_FLAGS or $RPM_BUILD_ROOT instead > of %{buildroot}. Fixed. > [NO] If the source package does not include license text(s) as a separate file > from upstream, the packager SHOULD query upstream to include it. > Please query the upstream about it. Asked upstream: https://code.google.com/p/mimeparse/issues/detail?id=14&thanks=14&ts=1321955989 > Some more comments: > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print get_python_lib()")} > is probably not needed any more. > The defattr is also not needed. Removed > Please consider running the included test as part of the build process. I run it now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review