Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678634 --- Comment #8 from Hedayat Vatankhah <hedayatv@xxxxxxxxx> 2011-11-21 12:26:00 EST --- Thanks for the (very tidy) review (and sorry for my not-that-good review). * Saaghar.x86_64: E: incorrect-fsf-address /usr/share/doc/Saaghar-0.9.69/README Saaghar.x86_64: W: no-manual-page-for-binary saaghar Both this problems are task for upstream. - I'll contact upstream about them. * Consider removing %defattr(-,root,root,-) - OK * Wouldn't it be better to use URL http://sourceforge.net/projects/saaghar/ ? Because I'm not able to switch http://pojh.iblogger.org/saaghar/ to english (there's probably not such an option) and the sourceforge page points to it anyway. - You're right. It is a non-English website. I'll update the URL as you suggested. * qt4-devel works ok, however correct package name is qt-devel - OK, will be fixed. * I think Saaghar-data should require base package, but it's probably not a problem as it is (i.e. when base package requires -data subpackage) - hmmm... the base package must require the subpackage in this case, but I'm not sure if it is also needed in the other way around. But I'll consider your suggestion and might add that dependency too. Thanks again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review