Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755602 --- Comment #2 from Matěj Cepl <mcepl@xxxxxxxxxx> 2011-11-21 13:52:25 EST --- (In reply to comment #1) My koji build is http://koji.fedoraproject.org/koji/taskinfo?taskID=3530449 > ==> Above is not a blocker but at least macro warning can be fixed using %% > instead % All commented macros are now eliminated, they are actually used now. > - source match with upstream as (sha1sum) > Ok I got confused here. upstream have latest today's commit with 0.9.0 tag > whereas packaged tarball is 0.9.1 version To make things even more confusing, it is now 0.9.2 (both in the upstream tag, at PyPI and in the package). > suggestions: > 1) If building this on Fedora only then you don't need > a) buidlroot > b) cleaning of buildroot in %install > c) %clean section > d) defattr(-,root,root,-) > > 2) Python sitelib macro not needed now in Fedora Package should be available even for EL-5. > 3) install command should preserve timestamp > http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps Just now using only python setup.py install. .spec file is at the same URL and .src.rpm at http://mcepl.fedorapeople.org/rpms/json_diff-0.9.2-1.el6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review