Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754088 --- Comment #2 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> 2011-11-21 06:08:54 EST --- MUST items: [YES] rpmplint is silent [YES] Package meets naming guidelines. [YES] Package meets packaging guidelines. [YES] Spec file matches base package name. [YES] License file is present, matching with spec file. [YES] Licensing Guidelines are met. [!] Spec file is legible and in American English. I would prefer summary like: Python module containing small set of classes used by both RestAuth server/client implementations or similar. Description differs for python and python3! The python3 description is probably for the restauth itself. [YES] Sources match upstream. [YES] Package builds OK. [!] BuildRequires are correct. I cannot find the python-setuptools-devel in rawhide. Is the python-setuptools really needed? It seems to build OK without it. [YES] Package doesn't bundle copies of system libraries. [YES] Package owns all the directories it creates. [YES] Package has no duplicity in %files. [YES] Permission on files are set properly. [NO] Spec file has consistant macro usage. Please use %{optflags} instead of $RPM_OPT_FLAGS or $RPM_BUILD_ROOT instead of %{buildroot}. [YES] Package is code or permissible content. [YES] %doc files don't affect runtime. [YES] Package doesn't own files/directories that other packages own. [YES] All files are valid UTF-8. Should items: [YES] Package builds in mock. [YES] Package uses sane scriptlets. Some more comments: There is extra space in both %doc (only cosmetic issue :) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} is probably not needed any more. The defattr is also not needed. AFAIK the above have only sense if it is planned to package for RHEL-5 EPEL. If so there should be also more additions (e.g. %clean section, ...). Please consider building and packaging the docs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review