Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691195 Mohamed El Morabity <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pikachu.2014@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pikachu.2014@xxxxxxxxx --- Comment #7 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2011-11-19 20:57:01 EST --- The package seems quite good at this point. I only have two comments: - you can remove the build root cleaning in %install, unless you plan to provide this package for EPEL5 too: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag - the guidelines recommand to provide a .desktop file to any graphical application: http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files I thought it was maybe useless for such an application, but Mandriva provides a desktop file in its wmnet packahg. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review