Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713122 --- Comment #16 from Till Maas <opensource@xxxxxxxxx> 2011-11-19 16:12:28 EST --- Some preliminary comments: - There is a spelling error: it's 'deprecated' and not 'deprecheated' - Leave the build section empty and add a comment that it is not needed instead of commenting it out. This will remove the following rpmlint warning:flyback.spec: W: no-%build-section - This seems to be wrong/not needed. Why do you do this? #add python headlines to python-scripts for file in src/*.py; do sed -i -e '1i#!/usr/bin/env python2' $file done - Why do you still use %{__install}? %{__install} -p -m 755 src/*.py %{buildroot}%{_datadir}/%{name}/ - The mode in the install command is wrong for all files except flyback.py. The other files do not need to be executable, therfore mode 644 is correct. - Actually you do not need to require python at all, because of the shebang in flyback.py /usr/bin/python will already be required automatically - The license is still problematic. According to the Google Project Page it is GPLv2 and not GPL+. Since the actual source does not contain any license header, it is afaik not even properly licensed as GPL+. Would you please ask upstream to add license headers as documented in http://www.gnu.org/licenses/gpl-howto.html ? - It seems that flyback upstream is not active anymore. Is this package really worht being added to Fedora? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review