Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564537 Carl van Tonder <carl@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NOTABUG | Keywords| |Reopened --- Comment #8 from Carl van Tonder <carl@xxxxxxxxxxxxxx> 2011-11-19 15:08:35 EST --- Finally had some time to revisit this. New package: Spec URL: http://supervacuo.com/fedora/grc.spec SRPM URL: http://supervacuo.com/fedora/grc-1.4-1.fc16.src.rpm (In reply to comment #5) > - The source code contains a man page. The rpm is missing that man page. Man pages now included > - There is a mixed use of spaces and tabs. Fixed. > - Please have a lot at https://fedoraproject.org/wiki/Packaging:Python I've read it thoroughly, and I'm not sure it's relevant. Although grc is written in Python, it is not (yet?) implemented as a Python module: it does not need to know where python_sitelib is, or do any byte-compilation. My interpretation is therefore that no changes are needed: I'd appreciate your advice if this is not so. > - Please get in touch with upstream about the license. COPYING is now also correctly included. The license is GPLv2 with some additions: one of them is that it can be re-licensed under any licence fulfilling Debian's guidelines. Should I leave it as-is, or change it to GPL? I've also updated to the latest upstream release, and am bypassing the included `install.sh` because it does not include all necessary files, anyway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review