Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755155 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2011-11-19 10:04:57 EST --- Review:- + koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3525421 + rpmlint on rpms gave perl-TAP-Harness-Multiple.noarch: E: incorrect-fsf-address /usr/share/doc/perl-TAP-Harness-Multiple-0.06/LICENSE 2 packages and 0 specfiles checked; 1 errors, 0 warnings. + source matched with upstream as (sha1sum) c889e977ae08fa9b57669e65c2e5769afc3fcbd5 TAP-Harness-Multiple-0.06.tar.gz c889e977ae08fa9b57669e65c2e5769afc3fcbd5 ../SOURCES/TAP-Harness-Multiple-0.06.tar.gz + make test gave All tests successful. Files=3, Tests=80, 1 wallclock secs ( 0.04 usr 0.01 sys + 1.18 cusr 0.30 csys = 1.53 CPU) + Package: perl-TAP-Harness-Multiple-0.06-1.fc17.noarch Provides: perl(TAP::Harness::Archive::MultipleHarnesses) = 0.06 perl(TAP::Harness::ReportByDescription) = 0.06 Requires: perl(File::Path) perl(File::Spec) perl(TAP::Harness) perl(TAP::Harness::Archive) perl(TAP::Harness::ReportByDescription) perl(base) perl(lib) perl(strict) + otherwise follows packaging guidelines Suggestions: 1) If building this on Fedora only then you don't need a) buidlroot b) cleaning of buildroot in %install c) %clean section d) defattr(-,root,root,-) 2) please remove explicit requires added in spec. yum should automatically pull the required dependencies. I see only following is automatically installed perl(TAP::Harness::Archive) perl(Test::Harness) so you should remove those 2 requires lines in SPEC. 3) Versioned Requires should be avoided. See http://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review