Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754975 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx> 2011-11-19 06:40:18 EST --- Just a brief look at the spec file: > Summary: Pion Network Library Please sum up what it does not what it is called. For example: Sumamry: C++ library for building lightweight HTTP interfaces > %package devel > Summary: Development files for pion-net > Requires: pion-net = %{version}-%{release} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %package doc > Summary: Documentation for pion-net > Requires: pion-net-devel = %{version}-%{release} It's a bad habit to let documentation depend on -devel packages. It makes it more difficult (if not impossible) to create a collection of documentation packages, because they require growing -devel trees to be installable. Surely one can read the docs without installing the -devel files. > %install > rm -rf %{buildroot} https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > %files > %doc AUTHORS COPYING NEWS TODO > %{_libdir}/libpion-*.so > %{_libdir}/pion/plugins/*.so https://fedoraproject.org/wiki/Packaging:UnownedDirectories -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review