Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754879 Josh Boyer <jwboyer@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(icon@fedoraprojec | |t.org) --- Comment #1 from Josh Boyer <jwboyer@xxxxxxxxxx> 2011-11-18 10:32:11 EST --- - Package meets naming and packaging guidelines - Spec file matches base package name. - Spec has consistant macro usage. - Meets Packaging Guidelines. - License - License field in spec matches - License file included in package - Spec in American English - Spec is legible. - Sources match upstream md5sum: Upstream doesn't release tarballs, but the git checkout of kup-0.3 matches - BuildRequires correct - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package is code or permissible content. - Packages %doc files don't affect runtime. - Package compiles and builds on at least one arch. - Package has no duplicate files in %files. - Package doesn't own any directories other packages own. - Package owns all the directories it creates. - No rpmlint output. [jwboyer@zod kup]$ rpmlint ~/rpmbuild/RPMS/noarch/kup-0.3-1.fc16.noarch.rpm kup.noarch: W: spelling-error %description -l en_US cryptographically -> photographically, typographically, topographically 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [jwboyer@zod kup]$ rpmlint ~/rpmbuild/RPMS/noarch/kup-server-0.3-1.fc16.noarch.rpm kup-server.noarch: W: spelling-error %description -l en_US cryptographically -> photographically, typographically, topographically kup-server.noarch: W: non-ghost-in-var-run /var/run/kup kup-server.noarch: E: non-standard-dir-perm /var/lib/kup/tmp 01777L kup-server.noarch: W: non-ghost-in-var-run /var/run/kup/lock kup-server.noarch: E: zero-length /var/run/kup/lock kup-server.noarch: W: no-manual-page-for-binary kup-server 1 packages and 0 specfiles checked; 2 errors, 4 warnings. [jwboyer@zod kup]$ rpmlint ~/rpmbuild/RPMS/noarch/kup-server-utils-0.3-1.fc16.noarch.rpm kup-server-utils.noarch: W: spelling-error %description -l en_US cryptographically -> photographically, typographically, topographically kup-server-utils.noarch: W: no-documentation kup-server-utils.noarch: W: no-manual-page-for-binary gpg-sign-all kup-server-utils.noarch: W: no-manual-page-for-binary genrings 1 packages and 0 specfiles checked; 0 errors, 4 warnings. [jwboyer@zod kup]$ rpmlint kup-0.3-1.fc16.src.rpm kup.src: W: spelling-error %description -l en_US cryptographically -> photographically, typographically, topographically kup.src: W: invalid-url Source0: kup-0.3.tar.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [jwboyer@zod kup]$ The warnings can be ignored, but the errors might need to be fixed. You should probably add a: Requires: gnupg2 as well. Otherwise gpg-sign-all and genrings aren't going to work very well. Other than that, it looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review