Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752223 --- Comment #34 from Ben Thompson <bct@xxxxxxxxx> 2011-11-17 15:49:04 EST --- Package Review (Informal) ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated ==== C/C++ ==== [x] : MUST - Header files in -devel subpackage, if present. [x] : MUST - Package does not contain any libtool archives (.la) ==== Generic ==== [x] : MUST - Package successfully compiles and builds into binary rpms on at least one supported architecture. [x] : MUST - Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).(EPEL6 & Fedora < 13) [x] : MUST - %config files are marked noreplace or the reason is justified. [x] : MUST - Each %files section contains %defattr [x] : MUST - Permissions on files are set properly. [x] : MUST - Package does not contain duplicates in %files. [x] : MUST - Spec file lacks Packager, Vendor, PreReq tags. [x] : MUST - Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of %install. (EPEL5) [x] : MUST - Package is named according to the Package Naming Guidelines. [!] : MUST - Rpmlint output is silent. rpmlint racoon2-debuginfo-20100526a-8.fc17.i686.rpm ================================================================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ================================================================================ rpmlint racoon2-20100526a-8.fc17.src.rpm ================================================================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ================================================================================ rpmlint racoon2-20100526a-8.fc17.i686.rpm ================================================================================ racoon2.i686: W: non-conffile-in-etc /etc/racoon2/hook/functions racoon2.i686: E: non-executable-script /etc/racoon2/hook/functions 0644L /bin/sh racoon2.i686: E: non-readable /etc/racoon2/transport_ike.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/racoon2.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/vals.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/tunnel_ike.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/local-test.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/tunnel_ike_natt.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/transport_kink.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/default.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/tunnel_kink.conf 0600L racoon2.i686: W: no-manual-page-for-binary iked racoon2.i686: W: dangerous-command-in-%post chmod 1 packages and 0 specfiles checked; 10 errors, 3 warnings. ================================================================================ [x] : MUST - Sources used to build the package matches the upstream source, as provided in the spec URL. /mnt/docs/development/fedora-git/FedoraReview/src/752223/racoon2-20100526a.tgz : MD5SUM this package : 2fa33abff1ccd6fc22876a23db77aaa8 MD5SUM upstream package : 2fa33abff1ccd6fc22876a23db77aaa8 [x] : MUST - Spec file is legible and written in American English. [x] : MUST - Spec file name must match the spec package %{name}, in the format %{name}.spec. [x] : MUST - File names are valid UTF-8. [x] : SHOULD - Reviewer should test that the package builds in mock. [x] : SHOULD - Dist tag is present. [!] : SHOULD - SourceX / PatchY prefixed with %{name}. Source0: http://ftp.racoon2.wide.ad.jp/pub/racoon2/racoon2-20100526a.tgz (racoon2-20100526a.tgz) Patch0: racoon2-autotools.patch (racoon2-autotools.patch) Patch1: racoon2-systemd.patch (racoon2-systemd.patch) [x] : SHOULD - SourceX is a working URL. [x] : SHOULD - Spec use %global instead of %define. Issues: [!] : MUST - Buildroot is correct (EPEL5 & Fedora < 10) Multiple BuildRoot definitions found [!] : MUST - Rpmlint output is silent. rpmlint racoon2-debuginfo-20100526a-8.fc17.i686.rpm ================================================================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ================================================================================ rpmlint racoon2-20100526a-8.fc17.src.rpm ================================================================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ================================================================================ rpmlint racoon2-20100526a-8.fc17.i686.rpm ================================================================================ racoon2.i686: W: non-conffile-in-etc /etc/racoon2/hook/functions racoon2.i686: E: non-executable-script /etc/racoon2/hook/functions 0644L /bin/sh racoon2.i686: E: non-readable /etc/racoon2/transport_ike.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/racoon2.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/vals.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/tunnel_ike.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/local-test.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/tunnel_ike_natt.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/transport_kink.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/default.conf 0600L racoon2.i686: E: non-readable /etc/racoon2/tunnel_kink.conf 0600L racoon2.i686: W: no-manual-page-for-binary iked racoon2.i686: W: dangerous-command-in-%post chmod 1 packages and 0 specfiles checked; 10 errors, 3 warnings. ================================================================================ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review