Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745510 --- Comment #17 from Alan Pevec <apevec@xxxxxxxxxx> 2011-11-17 08:25:01 EST --- (In reply to comment #16) > The Source0 file appears to be generated from git. This is fine, > but it would be better to have a comment stating how to regenerate > this file. I thought this was required by the review guidelines, > but I cannot find anything that says that now; It's here http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control > therefore this is not a review blocker. sourceurl guidelines do say "may" not "must" but IMHO it should be a review blocker, how would you rebuild and compare source tarball otherwise? > vdsm.x86_64: E: explicit-lib-dependency cyrus-sasl-lib > > Not quite sure what rpmlint is on about here. The dependency seems OK > to me. Seems to be packaging bug that cyrus-sasl-lib contains binaries, maybe better to put explicit: Requires(post): /usr/sbin/sasldblistusers2 Requires(post): /usr/sbin/saslpasswd2 ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review