Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700352 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> 2011-11-17 01:35:00 EST --- Review:- + koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3521258 + rpmlint on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source match with upstream as (sha1sum) 5fab8fcb9307b787de3831ff9e875c2a5f427bd5 DublinCore-Record-0.03.tar.gz 5fab8fcb9307b787de3831ff9e875c2a5f427bd5 ../SOURCES/DublinCore-Record-0.03.tar.gz + make test gave All tests successful. Files=6, Tests=135, 0 wallclock secs ( 0.04 usr 0.00 sys + 0.15 cusr 0.02 csys = 0.21 CPU) Result: PASS + Package: perl-DublinCore-Record-0.03-1.fc17.noarch Provides: perl(DublinCore::Element) = 0.03 perl(DublinCore::Record) = 0.03 Requires: perl(Carp) perl(Class::Accessor) perl(DublinCore::Element) perl(base) perl(strict) perl(warnings) + Follows packaging guidelines Suggestions: 1) If building this on Fedora only then you don't need a) buidlroot b) cleaning of buildroot in %install c) %clean section d) defattr(-,root,root,-) 2) yum will install automatically dependencies so remove perl(Class::Accessor) as Requires: 3)Changelog should add email address. See http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review