Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mailgraph - A RRDtool frontend for Mail statistics https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222552 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-01-26 19:10 EST ------- At the first glance: - usage of service and chkconfig in %pre/%post impose Require chkconfig,service - I am not sure that the location of the script /usr/share/mailgraph/mailgraph.cgi is correct. http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28Hierarchy%29%7C%28Filesystem%29%7C%28Standard%29#head-e1c5548cbbe551c7a43d375c524ab2ea0188557e states that Fedora "follows the [WWW] Filesystem Hierarchy Standard" which in turn says that /usr/share should be used for "Architecture-independent data". Since mailgraoh is a script (hence a program) rather than data, I'd say that according to http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28Hierarchy%29%7C%28Filesystem%29%7C%28Standard%29#head-69ef16dbc0ecb520d4cc7bbd381038f23963e1fd a better place could be %{_libexecdir}\%{name}. As an addition, rrd itself sits in /usr/bin. OTOH - awstats sits happily in /usr/share/awstats, so /usr/sahre has already been blessed in FE - mailman (from core) serves the scripts from /usr/lib/mailman/cgi-bin Someone with more experience, could you please step in ? Once we settle the above mentioned items, I'll be glad to do a pre-review (I cannot formaly review the package because you need a sponsor). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review