Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=747674 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> 2011-11-16 05:14:55 EST --- Review:- + koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3518307 + rpmlint on rpms gave perl-ZeroMQ.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/ZeroMQ/ZeroMQ.so ZeroMQ.so()(64bit) perl-ZeroMQ.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/ZeroMQ/ZeroMQ.so ZeroMQ.so()(64bit) 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + Source verified with upstream as (sha1sum) 4d96b2b89b57db8b1e80a6fa99d4c1d99713d5bc ZeroMQ-0.18.tar.gz 4d96b2b89b57db8b1e80a6fa99d4c1d99713d5bc ../SOURCES/ZeroMQ-0.18.tar.gz + make test All tests successful. Files=13, Tests=63, 8 wallclock secs ( 0.05 usr 0.02 sys + 0.73 cusr 0.11 csys = 0.91 CPU) + Package perl-ZeroMQ-0.18-1.fc17.x86_64 => Provides: ZeroMQ.so()(64bit) perl(ZeroMQ) = 0.18 perl(ZeroMQ::Constants) perl(ZeroMQ::Context) perl(ZeroMQ::Message) perl(ZeroMQ::Poller) perl(ZeroMQ::Raw) perl(ZeroMQ::Socket) Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) libuuid.so.1()(64bit) libzmq.so.1()(64bit) perl >= 0:5.008 perl(Carp) perl(Exporter) perl(IO::Handle) perl(Scalar::Util) perl(XSLoader) perl(ZeroMQ) perl(ZeroMQ::Constants) perl(ZeroMQ::Context) perl(ZeroMQ::Message) perl(ZeroMQ::Poller) perl(ZeroMQ::Raw) perl(ZeroMQ::Socket) perl(base) perl(strict) perl(warnings) rtld(GNU_HASH) Suggestions: 1) BR: on perl is really not needed 2) If building this on Fedora only then you don't need a) buidlroot b) cleaning of buildroot in %install c) %clean section d) defattr(-,root,root,-) 3) you don't need following explicit Requires: as they will get automatically pulled by yum Requires: perl(JSON) >= 2.00 Requires: perl(Task::Weaken) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review