Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #14 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-11-15 17:29:14 EST --- - As you are adding your own Makefiles anyway, could you use "install -p" there to preserve timestamps?: https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps - version is slightly wrong: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release Please use, e.g. %{date}git%{git_commit} (Out of curiosity, why do you use $git_commit and not a tagged release?) - License issues: You need to add a comment, which file has what license, for an example see: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios (It would make reviewing a lot easier, when you delete not needed directories either in %prep or when generating the source...) - $ rpmlint ~/rpmbuild/SRPMS/android-tools-20111115.4a25390-1.fc16.src.rpm ~/rpmbuild/RPMS/x86_64/android-tools-*20111115.4a25390* android-tools.src: W: spelling-error Summary(en_US) adb -> dab, adv, ad android-tools.src: W: spelling-error Summary(en_US) fastboot -> fast boot, fast-boot, fastball android-tools.src: W: spelling-error %description -l en_US adb -> dab, adv, ad android-tools.src: W: spelling-error %description -l en_US Fastboot -> Fast boot, Fast-boot, Fastball android-tools.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically android-tools.src: W: spelling-error %description -l en_US fastboot -> fast boot, fast-boot, fastball android-tools.src:15: W: macro-in-comment %{packdname} android-tools.src:15: W: macro-in-comment %{git_commit} android-tools.src:15: W: macro-in-comment %{packdname} android-tools.src: W: invalid-url Source0: core-4a25390.tar.xz android-tools.x86_64: W: spelling-error %description -l en_US Fastboot -> Fast boot, Fast-boot, Fastball android-tools.x86_64: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically android-tools.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/51-android.rules android-tools.x86_64: W: no-manual-page-for-binary adb android-tools.x86_64: W: no-manual-page-for-binary fastboot 3 packages and 0 specfiles checked; 0 errors, 15 warnings. - macro-in-comment: Please use two %%, so the warning is gone (you can't use the macros anyway) #################################################################### RFC: - non-conffile-in-etc: I don't consider udev rules as conf file... Anyone else here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review