Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754137 --- Comment #3 from Steve Traylen <steve.traylen@xxxxxxx> 2011-11-15 16:25:10 EST --- Quick first pass: 1) rpmlint of the .spec file ./nagios-plugins-bdii.spec:24: W: rpm-buildroot-usage %build make compile prefix=%{buildroot} It's odd that the build depends upon the buildroot. The build root is temporary location only used during the build and not in the final package, does the build and compile really depend upon this? ./nagios-plugins-bdii.spec: W: no-cleaning-of-buildroot %install Do you plan to target EPEL5 as well? in which case your %install needs a clean. 2) The nagios-plugins-bdii-1.0.11-1.fc16.x86_64.rpm package contains just one file. /usr/lib64/nagios/plugins/contrib/check_bdii_entries You don't require anything that contains or create the contrib directory yourself, see http://fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership more over I see no reason why this is in crontrib, no other nagios sensors appear to be, please can you be consistent to nagios-plugins which must be the reference I would guess. 2.5) Having absolutely no documentation is odd. Add a README.Fedora or ask upstream to include a README at the very least. 3) Url: vs URL: URL: is more conventional and it's an acronym after all. 4)The SPEC file says ASL 2.0 but there is no indication as to any license within the source code as far as I can see. Contact upstream and ask them to add a license or at the very least have them clarify the license, if that's all they do include the email reply. 5) BuildRequires: openldap-devel Include the architecture you require as well to avoid pointless package installs during resolution, ie. BuildRequires: openldap-devel%{?_isa} 6) Requires: openldap is not required since this is determined automatically and 7) The CFLAGS are incorrect: /usr/bin/gcc -Wall -O2 -g -DLDAP_DEPRECATED -lldap src/check_bdii_entries.c -o /builddir/build/BUILD/nagios-plugins-bdii-1.0.11/build/check_bdii_entries see http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review