Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656892 Jens Petersen <petersen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|notready cabal2spec | --- Comment #11 from Jens Petersen <petersen@xxxxxxxxxx> 2011-11-14 05:01:22 EST --- Thanks for updating I think I can review this for you as sponsor if you can clean up a little more: We usually put the summary and description in common_summary and common_description. Please remember to bump the release number and add a new changelog entry when you update the package. You should use _bindir and _datadir instead of explicitly writing /usr/bin and /usr/share. You can add (doc) files under the %file sections but you need to be careful since secondary archs don't have shared libraries (ie base subpackage). If you are serious about packaging it would also help if you looked at some other packages that need reviewing and posted comments on them - feel free to put links here to any reviews you have looked over. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review