Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752938 --- Comment #1 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2011-11-10 15:20:21 EST --- Talked on IRC and spec file has been updated. This review is based on the tarball from the srpm and the new spec file rpmlint: python-straight.plugin.noarch: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging [snip other spelling warnings] These are all false positives -- the words are common in computing. python-straight.plugin.src: W: invalid-url Source0: ironfroggy-straight.plugin-57ef11c.tar.gz There is a comment above the Source0 explaining how to retrieve the tarball from github so this is fine. Good: * License is BSD in source and spec * LICENSE file included * Spec file is legible * Sources match with upstream by following the github url to get the snapshot. * Package builds in koji for f16 * No localized files so no i18n concerns * Not a shared library package so no concerns there * No bundled libraries * Package owns the directories it creates and nothing more * Files listed once in the %files section * File permissions are correct * Macros used consistently * Code, not content * No large documentation files * Documentation is not used at runtime * Not a GUI app * No supbackages * All filenames are valid utf-8 Needswork: * Naming guidelines want "." replaced with "-" so this should be named python-straight-plugin. (and spec file renamed to match). Cosmetic: * Could BuildRequire: python2-devel instead of python-devel * The description says python3 compatible but you aren't building a python3 subpackage. I'd either build the subpackage or remove that line from the description. Fix the naming and I'll approve this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review