[Bug 751564] Review Request: The Aeolus Audrey Startup Agent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751564

--- Comment #24 from Jim Meyering <meyering@xxxxxxxxxx> 2011-11-10 10:13:46 EST ---
Hi Joe,
In the spec, this looks wrong:

  %if ! (0%{?fedora} > 14 || 0%{?rhel} > 6)
  Requires: python-argparse
  %endif

The problem is more apparent if you rewrite without the "!":

  %if (0%{?fedora} <= 14 && 0%{?rhel} <= 6)
  Requires: python-argparse
  %endif

Shouldn't it be || in place of && here?
(i.e., && in place of || in the original)

  %if (0%{?fedora} <= 14 || 0%{?rhel} <= 6)
  Requires: python-argparse
  %endif

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]