[Bug 530910] Review Request: hyena - Hyena is a library of GUI and non-GUI C# code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530910

--- Comment #14 from Ismael Olea <ismael@xxxxxxxx> 2011-11-10 08:34:06 EST ---
Review of hyena-0.5-1.fc14.src.rpm from Claudio:

* Compiling in F15 it needs mono-devel:

BuildRequires:  mono-devel

* You should remove all the execution permisions for the files don't need it.

* The setup -n parameter is redundant here

* About %configure, I would not activate tests, as is not an in development
version, but tests are not braking compilation so it's not necesary bad



Please apply the suggested changes and use mock for next rebuilds for better
control of potential collateral effects.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]