[Bug 607405] Review Request: poppler-sharp - C Sharp Bindings for Poppler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607405

--- Comment #8 from Ismael Olea <ismael@xxxxxxxx> 2011-11-10 07:15:45 EST ---
* rpmlint:

$ rpmlint -iv
/var/lib/mock/fedora-15-i386/result/poppler-sharp-0.0.2-2.fc15.src.rpm 
poppler-sharp.src: I: checking
poppler-sharp.src: I: checking-url http://www.github.com/jacintos/poppler-sharp
(timeout 10 seconds)
poppler-sharp.src: I: checking-url
http://github.com/downloads/jacintos/poppler-sharp/poppler-sharp-0.0.2.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

fine


$ rpmlint -iv
/var/lib/mock/fedora-15-i386/result/poppler-sharp-0.0.2-2.fc15.i686.rpm 
poppler-sharp.i686: I: checking
poppler-sharp.i686: I: checking-url
http://www.github.com/jacintos/poppler-sharp (timeout 10 seconds)
poppler-sharp.i686: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

poppler-sharp.i686: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

1 packages and 0 specfiles checked; 1 errors, 1 warnings.

here rpmlint not adheres to http://fedoraproject.org/wiki/Packaging:Mono, so
it's fine as it is.

[olea@patxuko rpmbuild]$ rpmlint -iv
/var/lib/mock/fedora-15-i386/result/poppler-sharp-devel-0.0.2-2.fc15.i686.rpm 
poppler-sharp-devel.i686: I: checking
poppler-sharp-devel.i686: I: checking-url
http://www.github.com/jacintos/poppler-sharp (timeout 10 seconds)
poppler-sharp-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.


if there is non trivial information to developers would be nice to add here; if
not, it is fine AFAIK




* I would suggest to modify translation from

%description -l es
Genera administración de enlaces a Poppler usando herramientas GAPI

to 

Genera los vínculos administrados usando las herramientas GAPI


* I understood, reading the linked issue 4 this modification is incompatible
now:

#libpoppler-glib fix https://github.com/jacintos/poppler-sharp/issues/4
sed -i 's/libpoppler-glib\.so\.6/libpoppler-glib\.so/g'
sources/poppler-sharp.dll.config

Correct me if I'm wrong.


* gacutil is now required to install DLL in Fedora (see
http://fedoraproject.org/wiki/Packaging:Mono#gacutil_in_a_spec_file)



Please apply the suggested changes and use mock for next rebuilds for better
control of potential collateral effects.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]