Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: XenMan - Graphical management tool for Xen https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222960 ------- Additional Comments From berrange@xxxxxxxxxx 2007-01-25 12:33 EST ------- Although I don't believe this is part of the formal packaging guidelines, the PAM config file that is included for the console-helper magic does not follow the standard used by other console-helper enabled apps. eg, xenman RPM installs a file containing # cat /etc/pam.d/xenman #%PAM-1.0 auth sufficient pam_rootok.so auth sufficient pam_timestamp.so auth include system-auth session required pam_permit.so session optional pam_xauth.so session optional pam_timestamp.so account required pam_permit.so While other apps typically delegate the config: # cat /etc/pam.d/system-config-network #%PAM-1.0 auth include config-util account include config-util session include config-util The latter config makes it easy to manage all the apps' PAM configs in one place. The app appears configured in /etc/xenman.conf to write to /var/log/xenman, but the RPM does not create this directory. I don't know if the application takes care of rotatings log files itself, but if not it installing a config into /etc/logrotate.d would be desirable. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review