Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=744948 Mario Blättermann <mariobl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mariobl@xxxxxxxxxx Flag| |fedora-review+ --- Comment #14 from Mario Blättermann <mariobl@xxxxxxxxxx> 2011-11-07 08:59:00 EST --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3494431 $ rpmlint -i -v * monochrome-icon-theme.src: I: checking monochrome-icon-theme.src: I: checking-url https://launchpad.net/ubuntu-mono (timeout 10 seconds) monochrome-icon-theme.src: W: invalid-url Source0: monochrome-icon-theme-0.0.37.tar.bz2 The value should be a valid, public HTTP, HTTPS, or FTP URL. monochrome-icon-theme.noarch: I: checking monochrome-icon-theme.noarch: I: checking-url https://launchpad.net/ubuntu-mono (timeout 10 seconds) monochrome-icon-theme.spec: W: invalid-url Source0: monochrome-icon-theme-0.0.37.tar.bz2 The value should be a valid, public HTTP, HTTPS, or FTP URL. 2 packages and 1 specfiles checked; 0 errors, 2 warnings. The warnings due to an invalid URL could be ignored, as already discussed in bug #744944. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPLv2 [+] MUST: The License field in the package spec file must match the actual license. [.] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [.] MUST: The sources used to build the package must match the upstream source. Due to that the original tarball needs to be re-packed to remove copyrighted files, it is impossible to verify the checksums. The bzip2 stack doesn't work always identically. [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [+] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. Tested in F15. Works as expected. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts. ---------------- PACKAGE APPROVED ---------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review