[Bug 751537] Review Request: gnome-shell-extension-weather - An extension for displaying weather notifications in GNOME Shell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751537

--- Comment #4 from M.M. <hal8600@xxxxxxxxxx> 2011-11-06 04:47:17 EST ---
(In reply to comment #3)

Thanks for your review and precious suggestions.


> Ok, unofficial review since I can't sponsor you.
> 
> 1. Always run rpmlint on the SRPM (and RPMs if you build them).


Ops, I forgot that.


> I got the following output:
> 
> $ rpmlint
> rpmbuild/gnome-shell-extension-weather/RPMS/noarch/gnome-shell-extension-weather-0-0.1.git4681a05.fc15.noarch.rpm 
> gnome-shell-extension-weather.noarch: E: description-line-too-long C
> gnome-shell-extension-weather is a simple extension for displaying weather
> notifications in GNOME Shell.
> gnome-shell-extension-weather.noarch: E: description-line-too-long C Currently,
> the weather report including forecast for today and tomorrow is fetched from
> Yahoo! Weather.
> 
> Basically you need to break your lines at 80 characters in the %description.


Done.


> 2. The following are not needed in your spec file and can be removed. (I would
> normally say, unless you going to build for EL5 or older versions of Fedora,
> but since this is for F16+, it's a given):
> 
> rm -rf %{buildroot} in %install
> %defattr(-,root,root,-) in %files


Removed.


> 3. There is a basic configuration gui in the tarball that's not installed by
> default. The files in the 3.0 branch are bad so I pulled them for Master for me
> but since it appears you're only planning to build for F16+ you should be able
> to use the ones in the tarball. I tried it out and it seemed to work. You still
> have to look up the WOEID manually but it has radio buttons for the other
> settings.
> 
> In %install I added:
> 
> install -D -pm 0755 weather-extension-configurator.py \
>         %{buildroot}%{_bindir}/weather-extension-configurator.py
> 
> desktop-file-install \
>         --dir=%{buildroot}%{_datadir}/applications \
>         weather-extension-configurator.desktop
> 
> In %files I added:
> 
> %{_bindir}/weather-extension-configurator.py
> %{_datadir}/applications/weather-extension-configurator.desktop


Added.
I also added "python" to the "Requires:" section and the commands needed to
compile the GSettings schemas (as suggested on the Fedora Wiki page
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema ).

Now rpmlint, executed on the .spec, the .src.rpm and the .rpm, returns:

gnome-shell-extension-weather.noarch: W: no-manual-page-for-binary
weather-extension-configurator.py
2 packages and 1 specfiles checked; 0 errors, 1 warnings.


Here are the links to the new SPEC and SRPM files:

Spec URL:
http://dl.dropbox.com/u/39458594/Fedora%20packages/gnome-shell-extension-weather_2/gnome-shell-extension-weather.spec

SRPM URL:
http://dl.dropbox.com/u/39458594/Fedora%20packages/gnome-shell-extension-weather_2/gnome-shell-extension-weather-0-0.1.git1bb2dd6.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]