Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726080 --- Comment #18 from Matthieu Saulnier <casper.le.fantom@xxxxxxxxx> 2011-11-03 12:45:56 EDT --- (In reply to comment #15) Spec URL: http://pingou.fedorapeople.org/RPMs/xnee.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/xnee-3.10-5.fc15.src.rpm > - Remove the exec perm from the header files Already done > - You can drop Requires: xnee-libs from the base package and from cnee. The > dependency is detected automatically. Done > - I recommend to replace the call of chrpath with the sed statements given > here: > http://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath > chrpath should only be used if none of the preferred methods work NOT done. I didn't succeed to build the package with sed statements. I tryed lot of drafts like this: sed -i 's|^0x0001_libdir_flag_spec=.*|0x0001_libdir_flag_spec=""|g' libtool sed -i 's|^0x0002_libdir_flag_spec=.*|0x0002_libdir_flag_spec=""|g' libtool sed -i 's|^0x0004_libdir_flag_spec=.*|0x0004_libdir_flag_spec=""|g' libtool sed -i 's|^0x0008_libdir_flag_spec=.*|0x0008_libdir_flag_spec=""|g' libtool sed -i 's|^0x0010_libdir_flag_spec=.*|0x0010_libdir_flag_spec=""|g' libtool sed -i 's|^0x0020_libdir_flag_spec=.*|0x0020_libdir_flag_spec=""|g' libtool sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool Maybe I haven't understood the wiki example... > - Change the Group of the libs package to "System Environment/Libraries" Done > - You can simplify the first rm statement in %install with > rm -f %{buildroot}%{_libdir}/*.{a,la} > Your variant is fine as well but in this case it's not necessary to list > each file explicitly. Done > - Please remove the "Encoding" entry from the .desktop file as it is > deprecated. > Also, add the missing semicolon after "Utility". Done > - Either remove "*.h" from %{_includedir}/libxnee/*.h in %files devel, or > add "%dir %{_includedir}/libxnee/". Otherwise, this directory is unowned and > won't be removed when you uninstall the package. Done ( "*.h" removed ) > - Don't add the doc files (AUTHORS, BUGS, etc.) multiple times. It's sufficient > to add them to the base package. The only exception is COPYING. You must > ensure that the license text of a package gets installed either directly or > indirectly through a dependent package. Thus, add COPYING to the libs > package. Done. I had to cnee the same doc files like xnee, because xnee isn't a dependancy of cnee. > - I suggest to add doc/xnee.pdf as additional %doc to the base package. It > contains useful information about the programs and might be helpful for > some users. Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review