Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rhts - A system for developing automated tests https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224271 ------- Additional Comments From bugs.michael@xxxxxxx 2007-01-24 18:40 EST ------- Some watch-the-spec findings: > %if %{hardcore_python_packaging} > Requires: python-abi = %(%{__python} -c "import sys ; print sys.version[:3]") > %endif Since FC4, "Requires: python(abi) =" is added by rpmbuild for Python modules below the versioned %_libdir/python* directory. > %build > [ "$RPM_BUILD_ROOT" != "/" ] && [ -d $RPM_BUILD_ROOT ] && rm -rf $RPM_BUILD_ROOT; > %clean > [ "$RPM_BUILD_ROOT" != "/" ] && [ -d $RPM_BUILD_ROOT ] && rm -rf $RPM_BUILD_ROOT; Superfluous. Nowadays BuildRoot cannot be '/' anymore. Apart from that, you would have a hard time finding anyone who has ever built an rpm with "--buildroot=/". > %install > DESTDIR=$RPM_BUILD_ROOT make install-noarch Here "rm -rf $RPM_BUILDROOT" at the beginning of %install is missing. You want to install into a clean buildroot always, not just with --short-circuit installs. > /usr/share/rhts/lib/rhts-make.include Directories /usr/share/rhts/ and /usr/share/rhts/lib/ are not included. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review