Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=747610 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #9 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxx> 2011-10-28 14:45:31 EDT --- Well, * Please check scriptlets again. https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache touch .... should be in %post and %postun, but gtk-update-icon-cache should be in %postun and %posttrans (both were in %post and %postun, however guideline changed on 2009-03). ref: http://lists.fedoraproject.org/pipermail/devel-announce/2009-April/000404.html https://fedoraproject.org/w/index.php?title=Packaging%3AScriptletSnippets&action=historysubmit&diff=89534&oldid=72483 * Now I don't think BR: scons is needed. Please fix above when importing this package into Fedora git. ------------------------------------------------------------- This pacakge (timeline) is APPROVED by mtasaka ------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review