Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746754 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069@xxxxxxxxx --- Comment #11 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-10-28 09:14:57 EDT --- Ok, a couple of updates. 1. The 'GNU/Linux (other POSIX-compatible systems should work too)' from the description should probably be removed as we don't care about other POSIX systems in this case, the package is only expected to work in Fedora. 2. Building with the current spec does not use the required CFLAGS. I fixed that like this, but a patch would be better. %prep %setup -q %patch0 -p1 # Update Makefile to use required CFLAGS sed -i 's/CFLAGS=/CFLAGS+=/g' Makefile %build CFLAGS='%{optflags}' export CFLAGS make %{?_smp_mflags} Get those fixed and I'll review it for you. I assume since the flag is not set that you do not need a sponsor, correct? Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review