Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746079 --- Comment #5 from James Laska <jlaska@xxxxxxxxxx> 2011-10-27 10:41:00 EDT --- Created attachment 530506 --> https://bugzilla.redhat.com/attachment.cgi?id=530506 rubygem-grit.spec (In reply to comment #4) > Thank you James... I've address the issue raised in comment 3. Updates found in > path "/V2" > > NOTE: The originals are still available in the original URLS. > > Spec URL: > http://joev.fedorapeople.org/V2/rubygem-grit.spec > > SRPM URL: > http://joev.fedorapeople.org/V2/rubygem-grit-2.4.1-1.fc15.src.rpm Minor note, some reviewers suggest that you bump the %release (with and appropriate %changelog entry) anytime a packaging change is made (even prior to review). This always feels weird for packages that aren't yet approved, but just thought I'd mention it for future package reviews (refer to https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs). [ OK ] The updated package/spec addresses the missing LICENSE file. rpmlint output looks good. [FAIL] The grit-2.4.1.gem included in the src.rpm payload no longer matches upstream. I'm not sure why, confirm how you are generating your src.rpm. # md5sum grit-*.gem* c8bee515d6eace9aec7336e0ac6b0768 grit-2.4.1.gem.downstream # included in src.rpm d41d8cd98f00b204e9800998ecf8427e grit-2.4.1.gem.upstream # from Source0 [WARN] I've patched your spec file to address some of the style warnings I posted in comment#2. I'd suggest reviewing the changes and taking them if you have no concerns. Feel free to question/debate/discuss (see attached diff). Please update the packages/spec to address the two points above, and we can proceed from there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review