Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=747437 --- Comment #6 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> 2011-10-26 22:50:55 EDT --- Note: The spec file linked to in comment 5 is not the same as the one included in the SRPM linked to in the same comment. (it seems like it is still the same as in your original submission, did you forget to reupload it? :) As such, I'm basing this comment on what is included in the SRPM. ----- You clarified the licensing situation to fix the only blocker I raise in comment 2. However, rpmlint now gives the following: $ rpmlint perl-Data-Properties* perl-Data-Properties.noarch: W: spelling-error %description -l en_US util -> til, utile, until perl-Data-Properties.noarch: E: non-readable /usr/share/doc/perl-Data-Properties-0.02/LICENSE 0600L perl-Data-Properties.src: W: spelling-error %description -l en_US util -> til, utile, until perl-Data-Properties.src: W: strange-permission LICENSE 0600L perl-Data-Properties.src:30: E: use-of-RPM_SOURCE_DIR perl-Data-Properties.spec:30: E: use-of-RPM_SOURCE_DIR 2 packages and 1 specfiles checked; 3 errors, 3 warnings. The following patch fixes the use-of-RPM_SOURCE_DIR errors: --- perl-Data-Properties.spec.orig 2011-10-27 10:41:38.706902133 +0800 +++ perl-Data-Properties.spec 2011-10-27 10:43:06.164055615 +0800 @@ -27,7 +27,7 @@ %prep %setup -q -n Data-Properties-%{version} -cp %_sourcedir/LICENSE . +cp %{SOURCE1} . %build %{__perl} Makefile.PL INSTALLDIRS=vendor See also: http://fedoraproject.org/wiki/Packaging:Guidelines#Improper_use_of_.25_sourcedir As for the non-readable error and the strange-permission warning, you could just run chmod +r on the source LICENSE file (not in the spec, on the actual source file, since you created it yourself anyway). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review