[Bug 740846] Review Request: espresso - Extensible Simulation Package for Research on Soft matter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=740846

--- Comment #9 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-10-26 17:48:43 EDT ---
Thanks for the review.

(In reply to comment #7)
> Taking for review.  I notice that the output of configure shows a Tk version of
> none.  If the Tk front-end is desirable, just adding --with-tk to each of the
> %dconfigure_mpi invocations and Requiring tk-devel does the trick.  If not,
> just ignore my pathetic attempt to be helpful. :-)

ok, added.

> sed -i 's/tclsh8\.4/tclsh/' tools/trace_memory.tcl

added and pull requested at:
https://github.com/ottxor/espresso/pull/2

The pdf documents aren't added, because I think upstream's documaintation is
better suited:
http://espressomd.org/wiki/Documentation
Anyone who really wants to have them, can download it there ;)

The no-documentation issues is an indication for having no COPYING in it, but
that's in common and anything R that, so it should be fine.

Changelog:
- use _isa where possible
- add missing BR autoconf/automake
  koji build successful:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=3462381

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]