Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=747849 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-10-25 19:25:28 EDT --- REVIEW: Good: - name ok - group ok - license ok - correct FLAGS used - contains static library (static provides partly ok (see below)) - install ok - %files ok - rpmlint ignorable: $ rpmlint ~/rpmbuild/RPMS/x86_64/e00compr-* ~/rpmbuild/SRPMS/e00compr-1.0.1-1.fc15.src.rpm e00compr.x86_64: W: spelling-error Summary(en_US) uncompress -> uncompressed, compression, compressor e00compr.x86_64: W: spelling-error %description -l en_US uncompress -> uncompressed, compression, compressor e00compr.src: W: spelling-error Summary(en_US) uncompress -> uncompressed, compression, compressor e00compr.src: W: spelling-error %description -l en_US uncompress -> uncompressed, compression, compressor 4 packages and 0 specfiles checked; 0 errors, 4 warnings. - koji build successfully: http://koji.fedoraproject.org/koji/taskinfo?taskID=3460389 - source match upstream: 6ab8ceadf8b63357aff88bca2da06355 e00compr-1.0.1.tar.gz Needswork: Requires: %{name}%{?_isa} = %{version}-%{release} Provides: %{name}-static = %{version}-%{release} Why not also provide with %{?_isa}? TODO: It would be great if upstream would provide the test files for the examples so they can be tested in a %check section. (But just a SHOULD here) ########################################################## Change the Provides to: Provides: %{name}-static%{?_isa} = %{version}-%{release} and it's: ########################################################## APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review