Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fvwm - window manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223724 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-01-23 20:26 EST ------- * regarding the license, I have spotted some files without license but with a mention to an author or even a copyright notice. When there is a copyright and no license, the default license is a restrictive license (no modification nor redistribution) which is non free and GPL incompatible. it is the case for bin/fvwm-config bin/fvwm-convert-2.2 (although the comments seem to indicate that it is public domain) bin/fvwm-convert-2.4 utils/fvwm_make_*.sh (although these are examples and so are likely in the public domain) modules/FvwmWharf/ASSound/ASSound.c * I think that the summary could be shortened, ICCM compliance and for the X Window system are not very informative. Maybe something along Summary: Highly configurable multiple virtual desktop window manager * fvwm-menu-headlines should use htmlview instead of netscape * fvwm-bug requires %{_sbindir}/sendmail * fvwm-menu-xlock requires xlock * fvwm-menu-directory could use mimeopen -n instead of EDITOR to open files. * in fvwm/ConfigFvwmSetup the default menu is badly suited for fedora. I propose removing rxvt, replacing the utility submenu a dynamically generated menu using the freedesktop standard. For that, I found a python script using pyxdg which could be suitable: http://www.cl.cam.ac.uk/~pz215/fvwm-scripts/scripts/xdg-menu.py However, I found 2 issues with that script, when calling it with xdg-menu.py /etc/xdg/menus/applications.menu > somefile 1. the accented characters make it break 2. the top level menu hasn't a reproducible name which could be handy to reference it in a Popup entry. I reported those issues upstream, with a patch to add a -m option to specify the toplevel menu name Then AddToMenu MenuFvwmUtilities could become something along: PipeRead "fvwm-xdg-menu-top -m MenuFvwmUtilities /etc/xdg/menus/applications.menu" * there is a missing Requires: xterm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review