Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=738590 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-10-25 07:48:08 EDT --- * Update to the latest version - Please consider updating to the latest version of gem. It seems it should incorporate the failed tests fix. * License is not clear - The license should be "Public Domain and MIT", however I rose the question upstream to clarify [1] * Please keep the note [2] about the "bundled" ruby_gettext_extractor in the spec file * Exclude the cached gem - The cached gem has no meaning in Fedora. I would suggest to use the following line in your spec: %exclude %{gemdir}/cache/%{gemname}-%{version}.gem * Keep Readme.md in the main package - The file contains the license information. It would be fine to keep it in the main package. * Keep the VERSION file in main package - This file is required by runtime: irb(main):002:0> require 'rubygems' => true irb(main):003:0> require 'gettext_i18n_rails' Errno::ENOENT: No such file or directory - /usr/lib/ruby/gems/1.8/gems /gettext_i18n_rails-0.2.20/lib/../VERSION from /usr/lib/ruby/gems/1.8/gems/gettext_i18n_rails-0.2.20 /lib/gettext_i18n_rails.rb:2:in `read' from /usr/lib/ruby/gems/1.8/gems/gettext_i18n_rails-0.2.20 /lib/gettext_i18n_rails.rb:2 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:59:in `gem_original_require' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:59:in `require' from (irb):3 from /usr/lib64/ruby/1.8/x86_64-linux/rbconfig.rb:172 - Note that it should not be marked by %doc macro in this case. [1] https://github.com/grosser/gettext_i18n_rails/issues/37 [2] https://github.com/retoo/ruby_gettext_extractor/issues/4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review