Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730970 --- Comment #9 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2011-10-24 13:01:38 EDT --- hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/build_src_unix.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/ug04treeview.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/ug03objects.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/ModularGuide/palette_view.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/ModularGuide/index.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/property_userblock.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/ModularGuide/io_classes.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/footer.js hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/image_indexed_mapping.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/hdf-obj.jpg hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/module_defaults.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/icon_folderclose.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_open_as.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/index.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/new_image.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/property_general_group.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/ug02start.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/save_as_text.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/menu_image.gif hdfview.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/RELEASE.txt hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/property_general_dataset.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_3d.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/ug06imageview.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/icon_table.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/tree_view.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/menu_window.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_reorder.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdf-data-links.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/phaseout_jhv.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/image_palette_modify.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/index.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/new_dataset.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/icon_image.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/file_manager.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_subset_nested.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_subset_example2.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/menu_popup.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_transpose.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/patch_notes.html hdfview.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/hdfview-2.7/docs/patch_notes.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/ModularGuide/default_modules.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_2d.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/ug01introduction.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/property_attribute.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/module_add_fileformat.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/menu_option_addfileformat.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_text.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_compound_2d.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/module_select_imageview.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/ModularGuide/components.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_subset_compound.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/icon_chart.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/image_true_color.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/build_src_windows.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/ModularGuide/property_file.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/chart_histogram.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/ModularGuide/hdfview.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/module_select_tableview.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/icon_dataset.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/design_components.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/ModularGuide/tree_view.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/hdfview.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/icon_hdf5.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/title.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/new_attribute.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/ug05spreadsheet.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/chart_line.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/menu_file.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_subset_example1.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/menu_option.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/image_contour.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/ModularGuide/attribute_view.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/menu_help.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/new_file.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/hdfview.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_subset_example3.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/ug07textview.html hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/icon_folderopen.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/ModularGuide/addfileformat.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/class_diagram_object.jpg hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/COPYING hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/header.js hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/image_palette.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/icon_hdf4.gif hdfview.noarch: W: spurious-executable-perm /usr/share/doc/hdfview-2.7/docs/hdfview/UsersGuide/images/dataset_compound.gif hdfview.noarch: W: no-manual-page-for-binary hdfview jhdf.x86_64: W: spurious-executable-perm /usr/share/doc/jhdf-2.7/COPYING jhdf5.x86_64: W: spurious-executable-perm /usr/share/doc/jhdf5-2.7/COPYING jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5util.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5sImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfvdataImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5oImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfsdsImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5util.h jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfr8Imp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfexceptionImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfstructsutil.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5Imp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5Constants.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/exceptionImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5zImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5rImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfheImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfr24Imp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfdfsdImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfhxImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfdfanImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfdfpalImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5dImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfgrImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfnativeImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5iImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5lImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5jni.h jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfdfuImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5eImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfvgroupImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfvqImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5aImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5fImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5tImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfvhImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5pImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfanImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfvfImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfvsqImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/nativeData.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdf5lib/h5gImp.c jhdf5-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/hdf-java/native/hdflib/hdfdfcompImp.c 5 packages and 0 specfiles checked; 1 errors, 129 warnings. 1. SHOULD: those are all mostly harmless, but could be avoided by removing the spurious-executable-perm's of the affected files prior to packaging (e.g. chmod -x in %prep somewhere) 2. MUST remove BuildRequires: rpm-build per https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 naming: OK license: OK scriptlets: NOT OK 3. MUST: looks like these (%post, %postun, etc...) all should be for the hdfview subpkg, not the main one. .desktop file validation: NOT OK 4. MUST: please run desktop-file-validate or desktop-file-install on /usr/share/applications/hdfview.desktop per https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage and note current errors: desktop-file-validate /usr/share/applications/hdfview.desktop /usr/share/applications/hdfview.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated /usr/share/applications/hdfview.desktop: error: (will be fatal in the future): value "hdfview.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path directory ownership: NOT OK 5. MUST add unowned dirs %_libdir/jhdf/ %_libdir/jhdf5/ probably easyfix, change %{_libdir}/jhdf5/*.jar and %{_libdir}/jhdf/*.jar to %{_libdir}/jhdf5/ and %{_libdir}/jhdf/ respectively (or add %dir entries, up to you). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review