Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690360 Miroslav Suchý <msuchy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |msuchy@xxxxxxxxxx Flag| |fedora-review? --- Comment #13 from Miroslav Suchý <msuchy@xxxxxxxxxx> 2011-10-23 18:59:02 EDT --- * LGPLv2.1 is unknown abbreviation of license. Check http://fedoraproject.org/wiki/Licensing:Main For LGPLv2.1 should be used just LGPLv2. * weave.src: W: invalid-url Source0: http://hg.mozilla.org/services/sync-server/archive/bc2f6caf8fc8.tar.bz2 - can you update it please (I know it is not your fault and it has been changed since April). * There is no need to specify build root now. http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag * similary to %clean section: http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean * Version: 20110314;Release: 1%{?dist} Hmm, according http://hg.mozilla.org/services/server-full they use version 0.1 number till August. I would recommend you reading of: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages And in April I would use: Version: 0.1 Release: 1.20110314hg If you would use version as you used, then upgrade to version e.g. 1.5 would be impossible without usage of epoch (which is alway good to avoid). * In weave.conf: #Alias /user/1.0 /usr/share/weave/reg-server-2a73b7376e2c/1.0/index.php #Alias /user/1 /usr/share/weave/reg-server-2a73b7376e2c/1.0/index.php Wow, that is ugly. That means, that whenever you modify your %{sync} and %{reg} macro (probably every release). Admin will have to manually upgrade weave.conf to have workable configuration. Why can't you just use reg-server and sync-server, without that commit number? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review