Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745233 --- Comment #1 from Robin Lee <robinlee.sysu@xxxxxxxxx> 2011-10-23 02:11:39 EDT --- Here is the review: +:ok, =:needs attention, -:needs fixing MUST Items: [+] MUST: rpmlint must be run on every package. $ rpmlint ./RPMS/noarch/python-manuel-1.5.0-1.fc15.noarch.rpm ./SRPMS/python-manuel-1.5.0-1.fc14.src.rpm ./SPECS/python-manuel.spec python-manuel.noarch: W: spelling-error %description -l en_US doctests -> doc tests, doc-tests, doctorates python-manuel.src: W: spelling-error %description -l en_US doctests -> doc tests, doc-tests, doctorates 2 packages and 1 specfiles checked; 0 errors, 2 warnings. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name} [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ md5sum Logbook-0.3.tar.gz f6db00f52bd4629b154c205252461719 Logbook-0.3.tar.gz [+] MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. [+] MUST: All build dependencies must be listed in BuildRequires [-] MUST: A package must own all directories that it creates. The directories %{python_sitearch}/Logbook-0.3-py2.7.egg-info/ and %{python3_sitearch}/Logbook-0.3-py3.2.egg-info/ should be owned. [+] MUST: A package must not contain any duplicate files in the %files listing. [-] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. * The macro upstream_name is not integrally used. * The macros python_sitelib, python_version and python3_version are defined but not used. [+] MUST: The package must contain code, or permissible content. This is described in detail in the code vs. content section of Packaging Guidelines. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [-] If the source code of the package provides a test suite, it should be executed in the %check section, whenever it is practical to do so. Test suite does not run. And should BuildRequires extra modules zmq, execnet, sqlalchemy to run as many tests as possible. Other Items: [-] According to setup.py, this package does not require setuptools and tkinter at runtime. [=] Group better be Development/Libraries [-] The summary of python3 package should use "Python 3" instead of "Python". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review