Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=747610 --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxx> 2011-10-22 15:15:53 EDT --- Some notes * License - README says that this software is GPLv3 only - icons/COPYING says that icons are under CC-BY-SA - So I think the License tag should be "GPLv3 and CC-BY-SA". * Unneeded specification - If you don't intend to import this into EPEL, the following items are no longer needed and should be removed. - BuildRoot line - "rm -rf $RPM_BUILD_ROOT" at the top of %install - %clean section entirely * BR - Is scons really needed? * Requires - Usually explicitly writing "hicolor-icon-theme" is not required. (I don't oppose to leave it though) * Macros - Please use macros when possible. For example /usr/share/man should be %{_mandir}. " Scriptlets - Please follow: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache (gtk-update-icon-cache oon %post moved to %posttrans) * Documents - "INSTALL" file is usually for people trying to build and install a package by themselves and not needed for people using rpm mechanism. Also please check the result of rpmlint. * gettext .po file issue - Check release/deb/debian/patches/fix-paths.patch and try to change LOCALE_DIR in main/timelinelib/paths.py. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review