Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: seedit: SELinux Policy Editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222594 ------- Additional Comments From ynakam@xxxxxxxxxxxxxx 2007-01-23 03:12 EST ------- (In reply to comment #10) Mamoru, thanks for comments. >Well, * BuildRequires, etc > - Firstly, I cannot check this package because mockbuild > fails on FC-devel i386. Please check the attached > log. Fixed. Added flex and byacc in buildrequires. > * File/Directory entries > - For main package, file entries include: > Please remove duplicate entries, then ensure that > every directories created during the install of > seedit related packages are owned by one package. Fixed. >* Requires >----------------------------------------------- >Requires: python >= 2.3 >----------------------------------------------- > This is not needed. Python version dependency is > automatically added by rpmbuild process. Fixed. >* %build process, etc... >----------------------------------------------- >--add-category X-Fedora >----------------------------------------------- > The category "X-???" is deprecated and should be > removed. Fixed. >------------------------------------------------ >install -m 664 %{SOURCE2} >------------------------------------------------ > Why should this be 0664, not 0644? It was only a mis-spell. Fixed. >* For header description: > Please change the URL of Source0 so that I can directly > gain the source by "wget -N .........". > Executing "wget -N" against this URL only pulls a HTML > file. Fixed. >* scriptlets: > ... By the way, what if user sets selinux policy as > "DISABLED"? There may be the case in which sysadmin > has to disable selinux for some reason. In the case, > selinux degree is "upgraded" to TARGETED? Hmm, I will reply in next comment. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review