Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: seedit: SELinux Policy Editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222594 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-01-23 02:02 EST ------- Created an attachment (id=146272) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=146272&action=view) Mock build log of on FC-devel i386 Well, * BuildRequires, etc - Firstly, I cannot check this package because mockbuild fails on FC-devel i386. Please check the attached log. * File/Directory entries - For main package, file entries include: --------------------------------------------- %{python_sitelib}/%{name} %{_datadir}/%{name} --------------------------------------------- And, for example -policy subpackage include: --------------------------------------------- %{_datadir}/%{name}/scripts/seedit-installhelper.sh ---------------------------------------------- ... Then seedit-installhelper.sh is installed in both main and -policy subpackage, because ---------------------------------------------- %{_datadir}/%{name} ---------------------------------------------- is interpretted as the directory %{_datadir}/%{name} itself _and_ all the files/directories etc under %{_datadir}/%{name}. If you want to indicate only the directory, you have to write: ---------------------------------------------- %dir %{_datadir}/%{name} ---------------------------------------------- Please remove duplicate entries, then ensure that every directories created during the install of seedit related packages are owned by one package. * Requires ----------------------------------------------- Requires: python >= 2.3 ----------------------------------------------- This is not needed. Python version dependency is automatically added by rpmbuild process. * %build process, etc... ----------------------------------------------- --add-category X-Fedora ----------------------------------------------- The category "X-???" is deprecated and should be removed. ------------------------------------------------ install -m 664 %{SOURCE2} ------------------------------------------------ Why should this be 0664, not 0644? * scriptlets: ... By the way, what if user sets selinux policy as "DISABLED"? There may be the case in which sysadmin has to disable selinux for some reason. In the case, selinux degree is "upgraded" to TARGETED? * For header description: ------------------------------------------------------ Source0: http://prdownloads.sourceforge.jp/selpe/23577/%{name}-%{version}-%{betatag}.tar.gz ------------------------------------------------------ Please change the URL of Source0 so that I can directly gain the source by "wget -N .........". Executing "wget -N" against this URL only pulls a HTML file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review