Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=747080 --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2011-10-19 13:26:09 EDT --- Fairly simple, and clean. naming: ok license: ok macros: ok scriptlets: ok patches: SHOULD: please document patches. what are they for? what does it fix? have you contacted upstream? if so, provide bug or mailing list references. sources: NOT OK $ md5sum *.bz2 27851bf2e675006885e7706fb91ee8af smb4k-0.10.10.tar.bz2 re-downloaded from upstream sources: 637ca913ffe9ac24a4dd09d4eddf0dcf smb4k-0.10.10.tar.bz2 MUST: regenerate srpm with pristine upstream sources -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review