Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699843 --- Comment #8 from Damian L Brasher <dlb@xxxxxxxxxxxxxxxxx> 2011-10-19 07:07:58 EDT --- Hi Martin I have spent some time bringing the dsi.spec closer in-line with package review guidelines. I'm expecting mistakes need to be corrected:) SPEC URL: http://dspaceinvadors.svn.sourceforge.net/viewvc/dspaceinvadors/dsi.spec?revision=208 SRPM URL: http://sourceforge.net/projects/dspaceinvadors/files/dsi-1.0.7-beta2/dsi-1.0.7-2.fc15.src.rpm [makerpm@fedora15 SPECS]$ rpmlint -i dsi.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [makerpm@fedora15 SRPMS]$ rpmlint -i dsi-1.0.7-2.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Notes: This is more complex than the previous package we worked on, a compiled C application with desktop elements. Please bear with me while mistakes are corrected. DSI broadens my scope as a fedora maintainer. Here are some technical issues to clarify: -I have set the platform to be i386, the lowest common denominator. Can this be the default for compatible platforms, i.e. i686? -I have used macros throughout, apart from CFLAGS="$RPM_OPT_FLAGS" does this need to be changed? -BuildRequires and Requires is present, with requirements, is this correct? -Is a man page required? -The resulting rpm installs and runs correctly on fedora15, as expected, but there is a warning about a world writeable file when rpmlint is run against the rpm: "dsi.i386: E: world-writable /var/lib/games/dsi/hiscore 0666L A file or directory in the package is installed with world writable permissions, which is most likely a security issue." should I change this? -There are most likely more issues to resolve, I appreciate your feedback, I am also reviewing documentation to cover new ground. Damian -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review