Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745510 --- Comment #12 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2011-10-18 14:16:20 EDT --- There's a few problems with the spec file. - '%define' should be '%global' throughout. - What was the reason for Conflicts: selinux-policy-targeted < ...? Could it not be: Requires: selinux-policy-targeted >= ... instead? - What's wrong with just dropping a new file into /etc/sudoers.d/? Anything in this directory is included, and it avoids the ugly %post script rewrite of sudoers. - Why is /etc/pki/vdsm/keys/libvirt_password not just a regular %config file in the %files section? In general anything that would reduce or eliminate those huge %pre/%post/%preun/%postun scripts would be a welcome change and will improve your life because you'll get fewer bug reports from unexpected user customizations. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review