Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746031 --- Comment #4 from Mo Morsi <mmorsi@xxxxxxxxxx> 2011-10-18 07:58:23 EDT --- > > Works good on an F16 system. It was failing on my f15 box since rubygem-rdoc > is not available there. Does 'rubygem-rdoc' need to be a BuildRequires? > No since rubygem-rdoc is just needed to build the sources and the BuildRequires are used to specify the dependencies required to build the package given the sources. > > Some additional comments from a rubygem review that vondruck performed > previously ... > > * Please execute test suite if available upstream. A bit tricky in our case since the test suite contains the tests for rubygem-aeolus-image and rubygem-aeolus-cli (seperate packages). This is not a blocker correct? > * I would suggest to move following files into -doc subpackage: > > %{geminstdir}/Gemfile > %{geminstdir}/Rakefile > %doc %{geminstdir}/minitest > %doc %{geminstdir}/test > %doc %{geminstdir}/spec > %doc %{geminstdir}/%{gemname}.gemspec > %doc %{geminstdir}/CHANGELOG.md > %doc %{geminstdir}/Guardfile Again this is a suggestion and isn't a blocker correct? (any more blockers for approval?). Either way is correct according to the guidelines (%doc macro or doc subpackage) and this can easily be done at any point in the future. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review